Re: [PATCH v2 3/5] crypto: talitos: Fix off-by-one and use all hardware slots
From: Kim Phillips <hidden>
Date: 2015-03-04 00:40:50
Also in:
linux-crypto
On Tue, 3 Mar 2015 08:21:35 -0500 Martin Hicks [off-list ref] wrote:
The submission count was off by one. Signed-off-by: Martin Hicks <redacted> ---
sadly, this directly contradicts:
commit 4b24ea971a93f5d0bec34bf7bfd0939f70cfaae6
Author: Vishnu Suresh [off-list ref]
Date: Mon Oct 20 21:06:18 2008 +0800
crypto: talitos - Preempt overflow interrupts off-by-one fix
My guess is your request submission pattern differs from that of
Vishnu's (probably IPSec and/or tcrypt), or later h/w versions have
gotten better about dealing with channel near-overflow conditions.
Either way, I'd prefer we not do this: it might break others, and
I'm guessing doesn't improve performance _that_ much?
If it does, we could risk it and restrict it to SEC versions 3.3 and
above maybe? Not sure what to do here exactly, barring digging up
and old 2.x SEC and testing.
Kim
p.s. I checked, Vishnu isn't with Freescale anymore, so I can't
cc him.