Thread (9 messages) flat view 9 messages, 4 authors, 2014-10-07

Re: [PATCH 1/4] powerpc/powernv: Add OPAL check token call

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-09-15 12:25:04

On Mon, 2014-09-15 at 13:10 +1000, Michael Ellerman wrote:
quoted
+enum OpalCheckTokenStatus {
+       OPAL_TOKEN_ABSENT = 0,
+       OPAL_TOKEN_PRESENT = 1
+};
I don't see this used anywhere?

And NoCamelCase !

Yes I know there's lots in that file, but I didn't merge that :)
The original OPAL APIs were like that and I chose to not "fix" them
because I've been aiming at reconciling the Linux and the FW versions
of the file, which I haven't had a chance to do yet (Cyril & Sam have
some WIP in that area afaik).

We could de-camelify them both but I'd rather do the reunification
first.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help