Re: [PATCH 1/4] powerpc/powernv: Add OPAL check token call

On Mon, 2014-09-15 at 13:10 +1000, Michael Ellerman wrote:

On Tue, 2014-08-19 at 14:47 +1000, Michael Neuling wrote:

quoted

Currently there is no way to generically check if an OPAL call exists o=

r not

quoted

from the host kernel.
=20
This adds an OPAL call opal_check_token() which tells you if the given =

token is

quoted

present in OPAL or not.
=20
Signed-off-by: Michael Neuling <redacted>
---
 arch/powerpc/include/asm/opal.h                | 7 +++++++
 arch/powerpc/platforms/powernv/opal-wrappers.S | 1 +
 2 files changed, 8 insertions(+)
=20

diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm=

/opal.h

quoted

index 86055e5..4593a93 100644

--- a/arch/powerpc/include/asm/opal.h
+++ b/arch/powerpc/include/asm/opal.h

@@ -135,6 +135,7 @@ struct opal_sg_list {
 #define OPAL_FLASH_MANAGE			77
 #define OPAL_FLASH_UPDATE			78
 #define OPAL_RESYNC_TIMEBASE			79
+#define OPAL_CHECK_TOKEN			80
 #define OPAL_DUMP_INIT				81
 #define OPAL_DUMP_INFO				82
 #define OPAL_DUMP_READ				83

@@ -417,6 +418,11 @@ struct opal_msg {
 	__be64 params[8];
 };

=20
+enum OpalCheckTokenStatus {
+       OPAL_TOKEN_ABSENT =3D 0,
+       OPAL_TOKEN_PRESENT =3D 1
+};

=20
I don't see this used anywhere?
=20
And NoCamelCase !

We can probably just delete the enum since we are just doing this in
code anyway:

       if (!opal_check_token(OPAL_RTC_READ))
               goto out;

OK?  Or would you prefer the usage to read:

       if (opal_check_token(OPAL_RTC_READ) =3D=3D OPAL_TOKEN_ABSENT)
               goto out;

Yes I know there's lots in that file, but I didn't merge that :)

Fickle bloody maintainers.  I thought I never say this but... I want our
crazy Frenchman back! :-P

Mikey