Re: [RFC PATCH] powerpc: Wire up three syscalls
From: Pranith Kumar <hidden>
Date: 2014-09-01 15:22:05
Also in:
lkml
From: Pranith Kumar <hidden>
Date: 2014-09-01 15:22:05
Also in:
lkml
Hi David, On Mon, Sep 1, 2014 at 7:33 AM, David Herrmann [off-list ref] wrote:
Nice catch. We changed 'flags' from u64 to "unsigned int" in the last revision of the series. Patch looks good, but I'd prefer using "unsigned int" as type, instead of __u32. Just to be consistent with the syscall interface. The return type of F_GET_SEALS is actually "int" and the MSB is reserved for signed error codes, so you can savely use "int r = fcntl(fd, F_GET_SEALS, 0)" in mfd_assert_get_seals().
OK. Should I send a new patch with these changes or do you have one line up already? -- Pranith