Re: [RFC PATCH] powerpc: Wire up three syscalls

Hi Pranith,

On Sun, Aug 31, 2014 at 2:52 PM, Pranith Kumar [off-list ref] wrote:

On Sun, Aug 31, 2014 at 4:53 AM, Geert Uytterhoeven
[off-list ref] wrote:

quoted

On Sat, Aug 30, 2014 at 5:36 AM, Pranith Kumar [off-list ref] wrote:

quoted

I see that the three syscalls seccomp, getrandom and memfd_create are not wired
because of which we get a warning while compilation.

So I wired them up in this patch. What else needs to be done? I tried the
memfd_test after compiling this kernel, but it is failing. What am I missing for
this to work? Any advice is really appreciated! :)

Did it fail due to the (silly) "ifeq ($(ARCH),X86)" checks in
tools/testing/selftests/memfd/Makefile?

I removed that check and compiled memfd_test.c by hand. This is the
following error which I get when I run the test:

$ ./memfd_test
memfd: CREATE
memfd: BASIC
10 != 0 = GET_SEALS(3)
Aborted

This is basically when checking the seals which we already added. It
should return 10 (F_SEAL_SHRINK | F_SEAL_WRITE), instead it is returning 0.

So it does fail.

What else needs to be done for this to properly work? I see that for
m68k, you just wired it up like in this patch. Did it work after that?

To be honest, I didn't run any tests.

I had a few spare minutes, so I wanted to give it a try, but "make kselftest"
doesn't work with building in a separate directory (O=), doesn't support
CROSS_COMPILE=, etc... So I gave up (for now).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds