RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

From: shengjiu.wang@freescale.com <hidden>
Date: 2014-08-19 09:05:08
Also in: alsa-devel, lkml

Hi Xiubo Li

     Lars-Peter has point out the root cause. It is caused by the SND_SOC_F=
SL_ASOC_CARD, which will select SND_SOC_IMX_PCM_DMA.

     Thank you very much anyway.

Best regards
Wang shengjiu

-----Original Message-----
From: Xiubo Li-B47053=20
Sent: Tuesday, August 19, 2014 5:00 PM
To: Wang Shengjiu-B02247
Cc: Lars-Peter Clausen; lgirdwood@gmail.com; broonie@kernel.org; perex@pere=
x.cz; tiwai@suse.de; nicoleotsuka@gmail.com; shc_work@mail.ru; Estevam Fabi=
o-R49496; xobs@kosagi.com; arnd@arndb.de; sfr@canb.auug.org.au; timur@tabi.=
org; alsa-devel@alsa-project.org; linuxppc-dev@lists.ozlabs.org; linux-kern=
el@vger.kernel.org
Subject: RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove depende=
nce of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

How about the following :

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d=

42f18c 100644

--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig

@@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC  config SND_SOC_FSL_SAI
        tristate "Synchronous Audio Interface (SAI) module support"
        select REGMAP_MMIO
-       select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n
+       select SND_SOC_IMX_PCM_DMA
        select SND_SOC_GENERIC_DMAENGINE_PCM
        help
          Say Y if you want to add Synchronous Audio Interface (SAI) @@ -25=

,7 +25,7 @@ config SND_SOC_FSL_SAI

 config SND_SOC_FSL_SSI
        tristate "Synchronous Serial Interface module support"
-       select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n
+       select SND_SOC_IMX_PCM_DMA
        select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC !=3D n && (MXC_TZIC || MX=
C_AVIC)
        select REGMAP_MMIO
        help

@@ -37,7 +37,7 @@ config SND_SOC_FSL_SSI  config SND_SOC_FSL_SPDIF
        tristate "Sony/Philips Digital Interface module support"
        select REGMAP_MMIO
-       select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n
+       select SND_SOC_IMX_PCM_DMA
        select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC !=3D n && (MXC_TZIC || MX=

C_AVIC)
        help
          Say Y if you want to add Sony/Philips Digital Interface (SPDIF) @=
@ -48,7 +48,7 @@ config SND_SOC_FSL_SPDIF  config SND_SOC_FSL_ESAI
        tristate "Enhanced Serial Audio Interface (ESAI) module support"
        select REGMAP_MMIO
-       select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n
+       select SND_SOC_IMX_PCM_DMA
        help
          Say Y if you want to add Enhanced Synchronous Audio Interface
          (ESAI) support for the Freescale CPUs.

@@ -76,6 +76,7 @@ config SND_SOC_FSL_ASOC_CARD

 config SND_SOC_IMX_PCM_DMA
        tristate
+       depends on SND_IMX_SOC
        select SND_SOC_GENERIC_DMAENGINE_PCM

 config SND_SOC_IMX_AUDMUX

Thanks,


BRs
Xiubo

-----Original Message-----
From: Shengjiu Wang [mailto:shengjiu.wang@freescale.com]
Sent: Tuesday, August 19, 2014 4:21 PM
To: Xiubo Li-B47053
Cc: Lars-Peter Clausen; lgirdwood@gmail.com; broonie@kernel.org;=20
perex@perex.cz; tiwai@suse.de; nicoleotsuka@gmail.com;=20
shc_work@mail.ru; Estevam Fabio-R49496; xobs@kosagi.com;=20
arnd@arndb.de; sfr@canb.auug.org.au; timur@tabi.org;=20
alsa-devel@alsa-project.org; linuxppc-dev@lists.ozlabs.org;=20
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove=20
dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA
=20
On Tue, Aug 19, 2014 at 04:13:15PM +0800, Xiubo Li-B47053 wrote:

quoted

Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig:=20
remove

dependence

quoted

of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote:

quoted

On 08/18/2014 10:38 AM, Shengjiu Wang wrote:

quoted

Build kernel with SND_SOC_IMC_PCM_DMA=3Dm && SND_IMX_SOC=3Dn leads=

=20

quoted

quoted
the

following

quoted

error:

   sound/built-in.o: In function `fsl_sai_probe':

quoted

fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_i=

nit'

quoted

   sound/built-in.o: In function `fsl_esai_probe':

quoted

fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_=

init'

quoted

Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init'

which is

quoted

defined in imx-pcm-dma.c, so need to select=20
SND_SOC_IMX_PCM_DMA, but it

depends

quoted

on SND_IMX_SOC, if SND_IMX_SOC=3Dn, then SND_SOC_IMX_PCM_DMA will=

=20

quoted

not be selected.
So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Shengjiu Wang <redacted>

Those if conditions where just added[1] by Arnd to avoid other=20
build failures. So just removing them again makes little sense.

As far as I can see imx_pcm_dma_init() should be stubbed out=20
when SND_SOC_IMX_PCM_DMA is not selected. So what's going on here?

[1]

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/
?id=3Dff40

quoted

260f79dc0436604452bccd449bffd25ebafb

quoted

Lars-Peter Clausen & Arnd

The purpose of Arnd's patch is same with me, which is to resolve=20
the build error when SND_SOC_IMX_PCM_DMA=3Dm &=20
SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=3Dy, the error is "undefined reference=

 to `imx_pcm_dma_init'".

quoted

But Arnd's patch didn't involve this situation that SND_IMX_SOC=3Dn=20
& SND_SOC_IMX_PCM_DMA=3Dm.

Currently I think out a solution for this issue is to change

select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n

to

depends on SND_SOC_IMX_PCM_DMA !=3D m

How do you think about this?

What will happen if to build both SAI/ESAI and IMX_PCM_DMA as=20
modules at the

same

quoted

time ?

Thanks,

BRs
Xiubo

=20
I didn't find error/warning when SAI/ESAI and IMX_PCM_DMA are as=20
modules. The build is successful.
=20

quoted

best regards
Wang shengjiu

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help