RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove depen=

dence

of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA
=20
On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote:

quoted

On 08/18/2014 10:38 AM, Shengjiu Wang wrote:

quoted

Build kernel with SND_SOC_IMC_PCM_DMA=3Dm && SND_IMX_SOC=3Dn leads the

following

quoted

quoted

error:

   sound/built-in.o: In function `fsl_sai_probe':

quoted

quoted

fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init'

   sound/built-in.o: In function `fsl_esai_probe':

quoted

quoted

fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init=

'

quoted

quoted

Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' whi=

ch is

quoted

quoted

defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but i=

t

depends

quoted

quoted

on SND_IMX_SOC, if SND_IMX_SOC=3Dn, then SND_SOC_IMX_PCM_DMA will not =

be

quoted

quoted

selected.
So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Shengjiu Wang <redacted>

Those if conditions where just added[1] by Arnd to avoid other build
failures. So just removing them again makes little sense.

As far as I can see imx_pcm_dma_init() should be stubbed out when
SND_SOC_IMX_PCM_DMA is not selected. So what's going on here?

[1]

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=

=3Dff40

260f79dc0436604452bccd449bffd25ebafb

quoted

Lars-Peter Clausen & Arnd
=20
The purpose of Arnd's patch is same with me, which is to resolve the buil=

d

error when SND_SOC_IMX_PCM_DMA=3Dm & SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=3Dy, =

the

error is "undefined reference to `imx_pcm_dma_init'".
But Arnd's patch didn't involve this situation that SND_IMX_SOC=3Dn &
SND_SOC_IMX_PCM_DMA=3Dm.
=20
Currently I think out a solution for this issue is to change
=20
select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC !=3D n
=20
to
=20
depends on SND_SOC_IMX_PCM_DMA !=3D m
=20
How do you think about this?
=20

What will happen if to build both SAI/ESAI and IMX_PCM_DMA as modules at th=
e same
time ?

Thanks,

BRs
Xiubo

best regards
Wang shengjiu