Thread (8 messages) flat view 8 messages, 1 author, 2014-07-12
STALE4428d

[PATCH 4/7] powerpc/sysfs: replace sscanf by kstrtol

From: Fabian Frederick <hidden>
Date: 2014-07-12 11:36:59
Also in: lkml
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

See checkpatch warning
"Prefer kstrto<type> to single variable sscanf"

Signed-off-by: Fabian Frederick <redacted>
---
 arch/powerpc/kernel/sysfs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c
index 67fd2fd..4293e4f 100644
--- a/arch/powerpc/kernel/sysfs.c
+++ b/arch/powerpc/kernel/sysfs.c
@@ -43,12 +43,11 @@ static ssize_t store_smt_snooze_delay(struct device *dev,
 				      size_t count)
 {
 	struct cpu *cpu = container_of(dev, struct cpu, dev);
-	ssize_t ret;
 	long snooze;
+	int rc = kstrtol(buf, 0, &snooze);
 
-	ret = sscanf(buf, "%ld", &snooze);
-	if (ret != 1)
-		return -EINVAL;
+	if (rc)
+		return rc;
 
 	per_cpu(smt_snooze_delay, cpu->dev.id) = snooze;
 	return count;
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help