[PATCH 2/7] powerpc/mv64x60_pci: replace sscanf by kstrtou32
From: Fabian Frederick <hidden>
Date: 2014-07-12 11:37:01
Also in:
lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
See checkpatch warning "Prefer kstrto<type> to single variable sscanf" Signed-off-by: Fabian Frederick <redacted> --- arch/powerpc/sysdev/mv64x60_pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/mv64x60_pci.c b/arch/powerpc/sysdev/mv64x60_pci.c
index 330d566..ca0b29c 100644
--- a/arch/powerpc/sysdev/mv64x60_pci.c
+++ b/arch/powerpc/sysdev/mv64x60_pci.c@@ -52,14 +52,17 @@ static ssize_t mv64x60_hs_reg_write(struct file *filp, struct kobject *kobj, { struct pci_dev *phb; u32 v; + int rc; if (off > 0) return 0; if (count <= 0) return -EINVAL; - if (sscanf(buf, "%i", &v) != 1) - return -EINVAL; + rc = kstrtou32(buf, 0, &v); + + if (rc) + return rc; phb = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0)); if (!phb)
--
1.9.1