Re: [RFC][PATCH] powerpc/CoreNet64: compile with CONFIG_E{5,6}500_CPU well

On Thu, 2013-11-21 at 16:59 +0800, "=E2=80=9Ctiejun.chen=E2=80=9D" wrote:

On 11/21/2013 12:41 AM, Scott Wood wrote:

quoted

On Wed, 2013-11-20 at 16:35 +0800, Tiejun Chen wrote:

quoted

+# Altivec and Spe options not allowed with e500mc64 in GCC.
+ifeq ($(call cc-option-yn,-mcpu=3De500mc64),n)
  obj-$(CONFIG_ALTIVEC)	+=3D xor_vmx.o
  CFLAGS_xor_vmx.o +=3D -maltivec -mabi=3Daltivec
+endif

This does not seem like the right fix.  What if GCC supports both
-mcpu=3De500mc64 and -mcpu=3De6500, and we're using the latter?  Or f=

or that

=20
I can understand what you mean, but in current kernel, -mcpu=3De500mc64=

 should be=20

excluded from -mcpu=3De6500,
=20
arch/powerpc/Makefile:
=20
E5500_CPU :=3D $(call cc-option,-mcpu=3De500mc64,-mcpu=3Dpowerpc64)
CFLAGS-$(CONFIG_E5500_CPU) +=3D $(E5500_CPU)
CFLAGS-$(CONFIG_E6500_CPU) +=3D $(call cc-option,-mcpu=3De6500,$(E5500_=

CPU))

But your patch doesn't test what options we're actually using.  You
tested what options the compiler supports.

But unfortunately, another place also use the same option,
=20
lib/raid6/Makefile:
=20
raid6_pq-$(CONFIG_ALTIVEC) +=3D altivec1.o altivec2.o altivec4.o altive=

c8.o

...
ifeq ($(CONFIG_ALTIVEC),y)
altivec_flags :=3D -maltivec -mabi=3Daltivec
endif
=20
Looks we have to do something in this common Makefile file as well, but=

 it may=20

-mcpu=3Dpower5)

  CFLAGS-$(CONFIG_POWER6_CPU) +=3D $(call cc-option,-mcpu=3Dpower6)
  CFLAGS-$(CONFIG_POWER7_CPU) +=3D $(call cc-option,-mcpu=3Dpower7)
=20
+# Altivec and Spe options not allowed with e500mc64 in GCC.
+ifeq ($(CONFIG_ALTIVEC),)
  E5500_CPU :=3D $(call cc-option,-mcpu=3De500mc64,-mcpu=3Dpowerpc64)
+else
+E5500_CPU :=3D -mcpu=3Dpowerpc64
+endif
  CFLAGS-$(CONFIG_E5500_CPU) +=3D $(E5500_CPU)
  CFLAGS-$(CONFIG_E6500_CPU) +=3D $(call cc-option,-mcpu=3De6500,$(E550=

0_CPU))

Reverse the if/else so it uses positive logic, and remove the irrelevant
SPE from the comment, but otherwise I guess it's OK.

-Scott