RE: [PATCH 02/12][v3] pci: fsl: add structure fsl_pci
From: Zang Roy-R61911 <hidden>
Date: 2013-10-24 04:15:30
Also in:
linux-arm-kernel, linux-pci
-----Original Message----- From: Kumar Gala [mailto:galak@kernel.crashing.org] Sent: Wednesday, October 23, 2013 11:11 PM To: Lian Minghuan-B31939 Cc: linuxppc-dev@lists.ozlabs.org list; Arnd Bergmann; Zang Roy-R61911; Wood Scott-B07421; Bjorn Helgaas; linux-pci@vger.kernel.org; linux-arm- kernel@lists.infradead.org Subject: Re: [PATCH 02/12][v3] pci: fsl: add structure fsl_pci =20 =20 On Oct 23, 2013, at 5:41 AM, Minghuan Lian wrote: =20quoted
PowerPC uses structure pci_controller to describe PCI controller, but ARM uses structure pci_sys_data. In order to support PowerPC and ARM simultaneously, the patch adds a structure fsl_pci that contains most of the members of the pci_controller and pci_sys_data. Meanwhile, it defines a interface fsl_arch_sys_to_pci() which should be implemented in architecture-specific PCI controller driver to convert pci_controller or pci_sys_data to fsl_pci. Signed-off-by: Minghuan Lian <redacted> --- change log: v1-v3: Derived from http://patchwork.ozlabs.org/patch/278965/ Based on upstream master. Based on the discussion of RFC version here http://patchwork.ozlabs.org/patch/274487/ include/linux/fsl/pci-common.h | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)=20 NAK. =20 We discussed this some at the ARM Summit this week and the feeling is we need to move to a common interface between the various ARCHs.
Can you share more about the *common interface*? Any plan to implement the * common interface*? Thanks. Roy