Re: [PATCH 02/12][v3] pci: fsl: add structure fsl_pci
From: Kumar Gala <hidden>
Date: 2013-10-24 04:11:07
Also in:
linux-arm-kernel, linux-pci
On Oct 23, 2013, at 5:41 AM, Minghuan Lian wrote:
PowerPC uses structure pci_controller to describe PCI controller, but ARM uses structure pci_sys_data. In order to support PowerPC and ARM simultaneously, the patch adds a structure fsl_pci that contains most of the members of the pci_controller and pci_sys_data. Meanwhile, it defines a interface fsl_arch_sys_to_pci() which should be implemented in architecture-specific PCI controller driver to convert pci_controller or pci_sys_data to fsl_pci. =20 Signed-off-by: Minghuan Lian <redacted> --- change log: v1-v3: Derived from http://patchwork.ozlabs.org/patch/278965/ =20 Based on upstream master. Based on the discussion of RFC version here http://patchwork.ozlabs.org/patch/274487/ =20 include/linux/fsl/pci-common.h | 41 =
+++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
NAK. We discussed this some at the ARM Summit this week and the feeling is we = need to move to a common interface between the various ARCHs. - k
quoted hunk ↗ jump to hunk
=20diff --git a/include/linux/fsl/pci-common.h =
b/include/linux/fsl/pci-common.h
quoted hunk ↗ jump to hunk
index 5e4f683..e56a040 100644--- a/include/linux/fsl/pci-common.h +++ b/include/linux/fsl/pci-common.h@@ -102,5 +102,46 @@ struct ccsr_pci {=20 }; =20 +/* + * Structure of a PCI controller (host bridge) + */ +struct fsl_pci { + struct list_head node; + bool is_pcie; + struct device_node *dn; + struct device *dev; + + int first_busno; + int last_busno; + int self_busno; + struct resource busn; + + struct pci_ops *ops; + struct ccsr_pci __iomem *regs; + + u32 indirect_type; + + struct resource io_resource; + resource_size_t io_base_phys; + resource_size_t pci_io_size; + + struct resource mem_resources[3]; + resource_size_t mem_offset[3]; + + int global_number; /* PCI domain number */ + + resource_size_t dma_window_base_cur; + resource_size_t dma_window_size; + + void *sys; +}; + +/* + * Convert architecture specific pci controller structure to fsl_pci + * PowerPC uses structure pci_controller and ARM uses structure =
pci_sys_data
+ * to describe pci controller. + */ +extern struct fsl_pci *fsl_arch_sys_to_pci(void *sys); + #endif /* __PCI_COMMON_H */ #endif /* __KERNEL__ */ --=20 1.8.1.2 =20