RE: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
From: Xiubo Li-B47053 <hidden>
Date: 2013-10-18 03:42:13
Also in:
alsa-devel, linux-arm-kernel, linux-devicetree
From: Xiubo Li-B47053 <hidden>
Date: 2013-10-18 03:42:13
Also in:
alsa-devel, linux-arm-kernel, linux-devicetree
quoted
quoted
I understand that, but I'm trying to figure out why of_iomap() is okay for hundreds of other drivers, but not this one. I've used it dozens of times myself, without ever worrying about overlappingregions. =20quoted
The driver would work fine with just of_iomap(). But the resource range check comes basically for free and it does help to catch errors, so I'd recommend on using it rather than not using it.=20 There's also the fact that it's a devm_ function which means less error handling code that we can break which is nice. There's probably a case for an improved OF helper here...
Using this instead of of_iomap() is because "devm_" and resource range chec= k as Lars and Mark said, and there are more than one SAI device here which wi= ll be added later, maybe the resource range check is needed. Thanks. -- BRS Xiubo