Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.
From: Lothar Waßmann <hidden>
Date: 2013-10-17 10:18:28
Also in:
alsa-devel, linux-arm-kernel, linux-devicetree, lkml
Hi, Xiubo Li [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When the CONFIG_REGULATOR is disabled there will be some warnings printed out. =20 Signed-off-by: Xiubo Li <redacted> --- sound/soc/codecs/sgtl5000.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) =20diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 1f4093f..4e2e4c9 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c@@ -883,14 +883,19 @@ static int ldo_regulator_register(struct snd_soc_co=
dec *codec,
struct regulator_init_data *init_data,
int voltage)
{
+#ifdef CONFIG_SND_SOC_FSL_SGTL5000
+ return 0;
+#else
dev_err(codec->dev, "this setup needs regulator support in the kernel\n=");
return -EINVAL; +#endif
This looks wrong to me, as this will disable the error for unsolicited platforms in a multi arch kernel!
static int ldo_regulator_remove(struct snd_soc_codec *codec)
{
return 0;
}
+
#endif
=20Why do you add an extra empty line here? Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________