Re: [RFC PATCH 01/11] kvm: powerpc: book3s hv: Fix vcore leak
From: Alexander Graf <hidden>
Date: 2013-09-27 11:39:37
On 27.09.2013, at 12:03, Aneesh Kumar K.V wrote:
From: Paul Mackerras <redacted> add kvmppc_free_vcores() to free the kvmppc_vcore structures that we allocate for a guest, which are currently being leaked. Signed-off-by: Paul Mackerras <redacted> Signed-off-by: Aneesh Kumar K.V <redacted>
This one doesn't look like an RFC to me. Applied to kvm-ppc-queue :). Alex
quoted hunk ↗ jump to hunk
--- arch/powerpc/kvm/book3s_hv.c | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 62a2b5a..edc7f9f 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c@@ -1931,10 +1931,20 @@ int kvmppc_core_init_vm(struct kvm *kvm)return 0; } +static void kvmppc_free_vcores(struct kvm *kvm) +{ + long int i; + + for (i = 0; i < KVM_MAX_VCORES; ++i) + kfree(kvm->arch.vcores[i]); + kvm->arch.online_vcores = 0; +} + void kvmppc_core_destroy_vm(struct kvm *kvm) { uninhibit_secondary_onlining(); + kvmppc_free_vcores(kvm); if (kvm->arch.rma) { kvm_release_rma(kvm->arch.rma); kvm->arch.rma = NULL; -- 1.8.1.2