Re: [PATCH 03/10] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

On 08/15/2013 05:43 PM, Alexander Graf wrote:

On 15.08.2013, at 09:42, Alexey Kardashevskiy wrote:

quoted

On 08/15/2013 05:25 PM, Alexander Graf wrote:

quoted

On 15.08.2013, at 09:24, Alexander Graf wrote:

quoted

On 15.08.2013, at 09:22, Alexey Kardashevskiy wrote:

quoted

On 08/15/2013 05:16 PM, Alexander Graf wrote:

quoted

On 01.08.2013, at 06:44, Alexey Kardashevskiy wrote:

quoted

This is to reserve a capablity number for upcoming support
of VFIO-IOMMU DMA operations in real mode.

Signed-off-by: Alexey Kardashevskiy <redacted>

---
Changes:
2013/07/16:
* changed the number

2013/07/11:
* changed order in a file, added comment about a gap in ioctl number

Signed-off-by: Alexey Kardashevskiy <redacted>
---
include/uapi/linux/kvm.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 99c2533..53c3f1f 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h

@@ -668,6 +668,7 @@ struct kvm_ppc_smmu_info {

#define KVM_CAP_IRQ_XICS 92
#define KVM_CAP_ARM_EL1_32BIT 93
#define KVM_CAP_SPAPR_MULTITCE 94
+#define KVM_CAP_SPAPR_TCE_IOMMU 95

#ifdef KVM_CAP_IRQ_ROUTING

@@ -933,6 +934,9 @@ struct kvm_s390_ucas_mapping {

#define KVM_ARM_SET_DEVICE_ADDR	  _IOW(KVMIO,  0xab, struct kvm_arm_device_addr)
/* Available with KVM_CAP_PPC_RTAS */
#define KVM_PPC_RTAS_DEFINE_TOKEN _IOW(KVMIO,  0xac, struct kvm_rtas_token_args)
+/* 0xad and 0xaf are already taken */

so 0xad and 0xaf are already taken? where?

Mistype :( s/af/ae/

They are taken in this file:

1016 /* VM is being stopped by host */
1017 #define KVM_KVMCLOCK_CTRL         _IO(KVMIO,   0xad)
1018 #define KVM_ARM_VCPU_INIT         _IOW(KVMIO,  0xae, struct kvm_vcpu_init)

Could you please make sure that whoever reads the comment in a year still knows where to look? :)

Something like

 /* 0xad is taken by KVM_KVMCLOCK_CTRL */
 /* 0xaf is taken by KVM_ARM_VCPU_INIT */

Missed this mail and reposted without this comment but updated commit
message saying where they are used. Repost again?

The commit message doesn't really help, since you don't see that one when you read the header file later. So yes, please.

Ok. Reposted as "[PATCH v8] KVM: PPC: reserve a capability and ioctl
numbers for realmode VFIO". Thank you. Sorry for my disturbing ignorance.


-- 
Alexey