On 15.08.2013, at 09:24, Alexander Graf wrote:

=20
On 15.08.2013, at 09:22, Alexey Kardashevskiy wrote:
=20

quoted

On 08/15/2013 05:16 PM, Alexander Graf wrote:

quoted

=20
On 01.08.2013, at 06:44, Alexey Kardashevskiy wrote:
=20

quoted

This is to reserve a capablity number for upcoming support
of VFIO-IOMMU DMA operations in real mode.
=20
Signed-off-by: Alexey Kardashevskiy <redacted>
=20
---
Changes:
2013/07/16:
* changed the number
=20
2013/07/11:
* changed order in a file, added comment about a gap in ioctl =

number

quoted

quoted

quoted

=20
Signed-off-by: Alexey Kardashevskiy <redacted>
---
include/uapi/linux/kvm.h | 4 ++++
1 file changed, 4 insertions(+)
=20

diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 99c2533..53c3f1f 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h

@@ -668,6 +668,7 @@ struct kvm_ppc_smmu_info {

#define KVM_CAP_IRQ_XICS 92
#define KVM_CAP_ARM_EL1_32BIT 93
#define KVM_CAP_SPAPR_MULTITCE 94
+#define KVM_CAP_SPAPR_TCE_IOMMU 95
=20
#ifdef KVM_CAP_IRQ_ROUTING
=20

@@ -933,6 +934,9 @@ struct kvm_s390_ucas_mapping {

#define KVM_ARM_SET_DEVICE_ADDR	  _IOW(KVMIO,  0xab, struct =

kvm_arm_device_addr)

quoted

quoted

quoted

/* Available with KVM_CAP_PPC_RTAS */
#define KVM_PPC_RTAS_DEFINE_TOKEN _IOW(KVMIO,  0xac, struct =

kvm_rtas_token_args)

quoted

quoted

quoted

+/* 0xad and 0xaf are already taken */

=20
so 0xad and 0xaf are already taken? where?

=20
Mistype :( s/af/ae/
=20
They are taken in this file:
=20
1016 /* VM is being stopped by host */
1017 #define KVM_KVMCLOCK_CTRL         _IO(KVMIO,   0xad)
1018 #define KVM_ARM_VCPU_INIT         _IOW(KVMIO,  0xae, struct =

kvm_vcpu_init)

=20
Could you please make sure that whoever reads the comment in a year =

still knows where to look? :)

Something like

  /* 0xad is taken by KVM_KVMCLOCK_CTRL */
  /* 0xaf is taken by KVM_ARM_VCPU_INIT */


Alex