On Thu, Jun 27, 2013 at 08:47:27PM -0500, Scott Wood wrote:

On 06/27/2013 08:36:37 PM, Kevin Hao wrote:

quoted

On Thu, Jun 27, 2013 at 02:58:34PM -0500, Scott Wood wrote:

quoted

On 06/26/2013 09:00:33 PM, Kevin Hao wrote:

quoted

This is based on the codes in the head_44x.S. Since we always

align to

quoted

quoted

256M before mapping the PAGE_OFFSET for a relocatable kernel,

we also

quoted

quoted

change the init tlb map to 256M size.

Why 256M?

For two reasons:
 1. This is the size which both e500v1 and e500v2 support.
 2. Since we always use the PAGE_OFFSET as 0xc0000000, the 256M is
    max alignment value we can use for this virtual address.

Is there any reason why 64M won't continue to work here?

Yes. In general we would map the 0 ~ 256M memory region in the first
tlb1 entry. If we align to 64M, the relocatable kernel would not work
if loaded above 64M memory. For example, if we load a relocatable kernel
at 64M memory, we will relocate it as:
	__pa(PAGE_OFFSET) = 0x4000000

But in map_mem_in_cams function, it will create a memory map as:
	__pa(PAGE_OFFSET) = 0x0

The kernel will definitely not work in this case.
	

quoted

quoted

This tightens the alignment requirement for dynamic memstart.

Yes. But since RELOCATABLE is a superset of DYNAMIC_MEMSTART, we
can always
use RELOCATABLE instead of DYNAMIC_MEMSTART for fsl booke board in
any cases.

The extra flexibility of RELOCATABLE may help some use cases, but
you'd still require the entire 256M naturally aligned region
containing the kernel to be present and owned by this instance of
Linux.

quoted

So DYNAMIC_MEMSTART will seem not so useful after we enable this
feature.

Then why doesn't this patch remove it?

According to the Kconfig it is still used by 44x. And maybe someone
still want to use this relocation method.

quoted

quoted

 And
what about boards with less than 256 MiB of RAM?

It should be fine. We just create the map in the tlb. The MM still use
the real size of memory.

No, you must not map anything that is not present with a mapping
that is executable and/or not guarded, or you could get speculative
accesses to who-knows-what.

Yes, there may be speculative access in this case.

 Even if RAM is present there but owned
by some other entity, you could be creating illegal aliases if that
other entity mapped it cache-inhibited or similar.

Fair enough. So it seems error prone if we map this 256M memory region
blindly. But if we don't do this, it seems that we have to do twice relocation.
The first time we just align to a predefined value (64M for example), and
then parse the device tree and get the real memstart_addr. After that we
should relocate the kernel to the real start address. It seems a little
complicated. Do you have any better ideas?

Thanks,
Kevin

-Scott