RE: [PATCH] powerpc: add Book E support to 64-bit hibernation
From: Wang Dongsheng-B40534 <hidden>
Date: 2013-04-07 03:01:56
-----Original Message----- From: Wood Scott-B07421 Sent: Thursday, April 04, 2013 4:16 AM To: Wang Dongsheng-B40534 Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation =20 On 04/03/2013 12:36:41 AM, Wang Dongsheng-B40534 wrote:quoted
quoted
-----Original Message----- From: Wood Scott-B07421 Sent: Wednesday, April 03, 2013 8:35 AM To: Wang Dongsheng-B40534 Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: add Book E support to 64-bithibernationquoted
On 04/02/2013 12:28:40 AM, Wang Dongsheng-B40534 wrote:quoted
Hi scott & Johannes, Thanks for reviewing. @scott, About this patch, could you please help ack this patch?Please investigate the issue of whether we are loading kernel module code in this step, and whether cache flushing is needed as a result.Sorry, I am not very clear what you mean. When the kernel boot end, modprobe some xx.ko?=20 Suppose, before the kernel was suspended, modules had been loaded. At what point do those modules get restored, and when does the cache get flushed? =20
Before the kernel was suspended, modules had been loaded, the modules is already in memory. And /lib/modules/* is belong to vfs. When suspend to disk, all used pages will be saved.(Include VFS, Loaded mod= ules) When restore, the kernel will not modprobe again. The non-bootcpu will restore all pages.(Include VFS, Loaded modules) So, It does not need to flush.