Re: [PATCH] powerpc: add Book E support to 64-bit hibernation
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2013-03-19 20:55:46
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2013-03-19 20:55:46
On Mon, 2013-03-18 at 17:12 -0500, Scott Wood wrote:
Could you elaborate on why book3s flushes the way it does? What's special about the first 32 MiB? If it's to cover kernel code, why would that be changing from what's already there?
I was going to say I have no idea, but looking at it again ... this is in the *resume* code, not the suspend code as I'd assumed, and on resume I guess I felt it was safer to not assume it didn't change, since it could be a slightly different kernel that loaded and restored the hibernation image? It should be the same one, so I guess it should be exactly the same code, but I guess I wanted to make sure there wasn't anything weird there. As for why it'd be 32 MiB? No idea. Although that really ought to flush all your possible caches anyway, I guess. johannes