RE: [PATCH 4/5 v11] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

-----Original Message-----
From: Joerg Roedel [mailto:joro@8bytes.org]
Sent: Tuesday, April 02, 2013 8:40 PM
To: Sethi Varun-B16395
Cc: Yoder Stuart-B08248; Wood Scott-B07421; iommu@lists.linux-
foundation.org; linuxppc-dev@lists.ozlabs.org; linux-
kernel@vger.kernel.org; galak@kernel.crashing.org;
benh@kernel.crashing.org
Subject: Re: [PATCH 4/5 v11] iommu/fsl: Add additional iommu attributes
required by the PAMU driver.
=20
On Fri, Mar 29, 2013 at 01:24:01AM +0530, Varun Sethi wrote:

quoted

+/* cache stash targets */
+enum stash_target {
+	IOMMU_ATTR_CACHE_L1 =3D 1,
+	IOMMU_ATTR_CACHE_L2,
+	IOMMU_ATTR_CACHE_L3,
+};
+
+/* This attribute corresponds to IOMMUs capable of generating
+ * a stash transaction. A stash transaction is typically a
+ * hardware initiated prefetch of data from memory to cache.
+ * This attribute allows configuring stashig specific parameters
+ * in the IOMMU hardware.
+ */
+
+struct iommu_stash_attribute {
+	u32 	cpu;	/* cpu number */
+	u32 	cache;	/* cache to stash to: L1,L2,L3 */
+};
+

=20
I would prefer these PAMU specific enum and struct to be in a pamu-
specific iommu-header.
=20

[Sethi Varun-B16395] But, these would be used by the IOMMU API users (e.g. =
VFIO), they shouldn't depend on PAMU specific headers.

-Varun