On Fri, 2013-03-08 at 11:38 +0800, Chen Gang wrote:

quoted

  originally I did not notice src buf len and dest buf len are the =

same.

quoted

    so origianlly, it is not a bug issue, it is only for beautify =

code.

quoted

    and now, using strcpy is better.

=20
Being the same len doesn't mean it's safe to use strcpy ... the source
might be missing the 0 terminator. In this specific case though, I
believe the source string comes was itself populated with strlcpy
(at least since your patch 6b6680c4ea3952af8ae76915cbca41245147741b) =

so

strcpy is indeed safe but using strlcpy doesn't hurt does it ?

Using strlcpy() also stops someone else having to check it
again in a few years time.

	David