Re: [PATCH] drivers/tty/hvc: fixup original commit: 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2013-03-08 03:46:22
On Fri, 2013-03-08 at 11:38 +0800, Chen Gang wrote:
originally I did not notice src buf len and dest buf len are the same.
so origianlly, it is not a bug issue, it is only for beautify code.
and now, using strcpy is better.Being the same len doesn't mean it's safe to use strcpy ... the source might be missing the 0 terminator. In this specific case though, I believe the source string comes was itself populated with strlcpy (at least since your patch 6b6680c4ea3952af8ae76915cbca41245147741b) so strcpy is indeed safe but using strlcpy doesn't hurt does it ? Ben.
quoted hunk ↗ jump to hunk
Signed-off-by: Chen Gang <redacted> Signed-off-by: Jiri Slaby <redacted> --- drivers/tty/hvc/hvcs.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index 81e939e..9330a4b 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c@@ -885,8 +885,7 @@ static void hvcs_set_pi(struct hvcs_partner_info*pi, struct hvcs_struct *hvcsd) hvcsd->p_partition_ID = pi->partition_ID; /* copy the null-term char too */ - strlcpy(&hvcsd->p_location_code[0], - &pi->location_code[0], sizeof(hvcsd->p_location_code)); + strcpy(&hvcsd->p_location_code[0], &pi->location_code[0]); } /*