Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

Le mardi 29 janvier 2013 19:13:06, Jason Gunthorpe a =E9crit :

On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote:

quoted

This patch converts the Marvell MV643XX ethernet driver to use the
Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms
registering the Marvell MV643XX ethernet driver are also updated to
register a Marvell Orion MDIO driver. This driver voluntarily overlaps
with the Marvell Ethernet shared registers because it will use a subset
of this shared register (shared_base + 0x4 - shared_base + 0x84). The
Ethernet driver is also updated to look up for a PHY device using the
Orion MDIO bus driver.

=20
Can you finish off this job by making the mv643xx_eth driver accept
the standard phy-handle OF property instead of using a phy address?

I can certainly do that, at the same time we need to continue supporting th=
e=20
"old" platform device style registration without breaking them (PowerPC in=
=20
particular, and the hopefully yet to be converted orion5x). So the phy_scan=
()=20
as I modified it will probably still be there.

=20
Ie the end result should be something like:
=20
                smi0: mdio@72000 {
                        device_type =3D "mdio";
                        compatible =3D "marvell,orion-mdio";
                        reg =3D <0x72004 0x4>;
=20
                        #address-cells =3D <1>;
                        #size-cells =3D <0>;
                        PHY1: ethernet-phy@1 {
                                reg =3D <1>;
                                device_type =3D "ethernet-phy";
                                phy-id =3D <0x01410e90>;
                        };
                };
=20
                egiga0 {
                        device_type =3D "network";
                        compatible =3D "marvell,mv643xx-eth";
                        reg =3D <0x72000 0x4000>;
                        port_number =3D <0>;
                        phy-handle =3D <&PHY1>;
                        interrupts =3D <11>;
                        local-mac-address =3D [000000000002];  /* Filled =

by

boot loader */ };
=20
Regards,
Jason

=2D-=20
=46lorian