RE: [PATCH 3/4 v5] iommu/fsl: Add iommu domain attributes required by fsl PAMU driver.
From: Sethi Varun-B16395 <hidden>
Date: 2012-11-26 05:24:42
Also in:
linux-iommu, lkml
Hi Joerg, Any comments? Can we apply this patch? Regards Varun
quoted hunk ↗ jump to hunk
-----Original Message----- From: Sethi Varun-B16395 Sent: Tuesday, November 20, 2012 7:25 PM To: joerg.roedel@amd.com; iommu@lists.linux-foundation.org; linuxppc- dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood Scott-B07421; Tabi Timur-B04825 Cc: Sethi Varun-B16395 Subject: [PATCH 3/4 v5] iommu/fsl: Add iommu domain attributes required by fsl PAMU driver. =20 Added the following domain attributes required by FSL PAMU driver: 1. Subwindows field added to the iommu domain geometry attribute. 2. Added new iommu stash attribute, which allows setting of the LIODN specific stash id parameter through IOMMU API. 3. Added an attribute for enabling/disabling DMA to a particular memory window. =20 Signed-off-by: Varun Sethi <redacted> --- changes in v5: - Updated description of the subwindows field. changes in v4: - Updated comment explaining subwindows(as mentioned by Scott). change in v3: -renamed the stash attribute targets include/linux/iommu.h | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 43 insertions(+), 0 deletions(-) =20diff --git a/include/linux/iommu.h b/include/linux/iommu.h indexf3b99e1..7ca1cda 100644--- a/include/linux/iommu.h +++ b/include/linux/iommu.h@@ -44,6 +44,41 @@ struct iommu_domain_geometry { dma_addr_t aperture_start; /* First address that can be mapped*/ dma_addr_t aperture_end; /* Last address that can be mapped */ bool force_aperture; /* DMA only allowed in mappable range? */ + + /* + * A geometry mapping can be created in one of the following ways + * for an IOMMU: + * 1. A single contiguous window + * 2. Through arbritary paging throughout the aperture. + * 3. Using multiple subwindows + * + * In absence of arbritary paging, subwindows allow for supporting + * physically discontiguous mappings. + * + * This attribute indicates number of DMA subwindows supported by + * the geometry. If there is a single window that maps the entire + * geometry, attribute must be set to "1". A value of "0" implies + * that this mechanism is not used at all(normal paging is used). + * Value other than* "0" or "1" indicates the actual number of + * subwindows. + */ + u32 subwindows; +}; + +/* cache stash targets */ +#define IOMMU_ATTR_CACHE_L1 1 +#define IOMMU_ATTR_CACHE_L2 2 +#define IOMMU_ATTR_CACHE_L3 3 + +/* This attribute corresponds to IOMMUs capable of generating + * a stash transaction. A stash transaction is typically a + * hardware initiated prefetch of data from memory to cache. + * This attribute allows configuring stashig specific parameters + * in the IOMMU hardware. + */ +struct iommu_stash_attribute { + u32 cpu; /* cpu number */ + u32 cache; /* cache to stash to: L1,L2,L3 */ }; =20 struct iommu_domain {@@ -60,6 +95,14 @@ struct iommu_domain { enum iommu_attr { DOMAIN_ATTR_MAX, DOMAIN_ATTR_GEOMETRY, + /* Set the IOMMU hardware stashing + * parameters. + */ + DOMAIN_ATTR_STASH, + /* Explicity enable/disable DMA for a + * particular memory window. + */ + DOMAIN_ATTR_ENABLE, };=20 #ifdef CONFIG_IOMMU_API -- 1.7.4.1