Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2012-10-25 00:35:43
Also in:
lkml
Hi Felipe, On Monday 22 October 2012 13:56:01 Felipe Balbi wrote:
On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote:quoted
On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:quoted
On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:quoted
On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote:quoted
Some gadget drivers may attempt to dequeue requests for an endpoint that has already been disabled. For example, in the UVC gadget driver, uvc_function_set_alt() will call usb_ep_disable() when alt setting 0 is selected. When the userspace application subsequently issues the VIDIOC_STREAMOFF ioctl, uvc_video_enable() invokes usb_ep_dequeue() to ensure that all requests have been cancelled.bug is on uvc gadget, then. Laurent ?We've discussed this topic a couple of months before. I believe that's not a bug. http://68.183.106.108/lists/linux-usb/msg68869.htmlfair enough :-) That's a different case, however. At the link above we're discussing dequeueing a request which is already being dequeued. $SUBJECT is trying to fix dequeueing of a request for an endpoint which isn't even enabled.
You've got a point there :-) That's a different case indeed, I'm open to (at least evaluating) a fix in the UVC gadget driver if you think that's better. -- Regards, Laurent Pinchart
Attachments
- signature.asc [application/pgp-signature] 490 bytes