Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

From
Felipe Balbi <hidden>
Date
2012-10-22 11:02:00
Also in
lkml
Reply to
Laurent Pinchart, 2012-10-22
Hi,

On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote:
Hi,

On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:
quoted
On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:
quoted
On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote:
quoted
Some gadget drivers may attempt to dequeue requests for an endpoint
that has already been disabled. For example, in the UVC gadget driver,
uvc_function_set_alt() will call usb_ep_disable() when alt setting 0
is selected. When the userspace application subsequently issues the
VIDIOC_STREAMOFF ioctl, uvc_video_enable() invokes usb_ep_dequeue() to
ensure that all requests have been cancelled.

bug is on uvc gadget, then. Laurent ?
We've discussed this topic a couple of months before. I believe that's not a 
bug.

http://68.183.106.108/lists/linux-usb/msg68869.html
fair enough :-)

That's a different case, however. At the link above we're discussing
dequeueing a request which is already being dequeued. $SUBJECT is trying
to fix dequeueing of a request for an endpoint which isn't even enabled.

-- 
balbi

Attachments

Thread (10 messages) 10 messages, 4 authors, last reply 2012-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help