RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
From: Huang Changming-R66093 <hidden>
Date: 2012-09-18 01:10:00
Also in:
linux-mmc
From: Huang Changming-R66093 <hidden>
Date: 2012-09-18 01:10:00
Also in:
linux-mmc
On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: =20quoted
Hi, On Thu, Sep 13 2012, Kumar Gala wrote:quoted
quoted
quoted
Can you list out which SoCs support it and which don't. Having this list will be useful in understanding which controller versionssupported it.quoted
quoted
quoted
quoted
P1020, p1021, p1022, p1024, p1015 and p4080 can't support it. Mpc8536, p2020, and the other current DPAA silicon (e.g. p5020, p3041=
)
support it.quoted
quoted
Based on this, why don't we use the HOSTVER register to detect insteadof device tree:quoted
I've got a mild preference for handling quirk assignment in the DT rather than in driver code, so I'd prefer to just push the original patch to mmc-next as-is. Does that sound okay?=20 Why? I only ask because I agree with Scott that this means you have to update your device tree to get proper functionality. =20
When the new silicon does not support CMD23, if we don't update the device tree, then we must update the SDHC driver. I prefer to add the property in device tree, because we just add this property in new device tree, we don't need more ef= fort to modify driver.