Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

On Sep 11, 2012, at 4:36 AM, Huang Changming-R66093 wrote:

Thanks, Anton.
If it is necessary, I will resend this patch to =

linuxppc-dev@lists.ozlabs.org.

=20
Best Regards
Jerry Huang

I'm still not convinced this is the way to handle this issue.  It seems =
as if the linux driver code makes some assumptions about CMD23 support =
that it shouldn't.

- k

=20
=20

quoted

-----Original Message-----
From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
Sent: Tuesday, September 11, 2012 4:05 PM
To: Huang Changming-R66093
Cc: linux-mmc@vger.kernel.org; Kumar Gala; =

linuxppc-dev@lists.ozlabs.org

quoted

Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the =

CMD23

quoted

=20
On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote:

quoted

On Tue, Sep 11, 2012 at 03:12:44PM +0800, Chang-

Ming.Huang@freescale.com wrote:

quoted

quoted

From: Jerry Huang <redacted>
=20
Below SOCs don't support the cmd23 command for MMC card, therefore,
disable it in device tree:
P1020, P1021, P1022, P1024, P1025 and P4080
=20
Signed-off-by: Jerry Huang <redacted>

=20
Acked-by: Anton Vorontsov <redacted>

=20
Btw, although the patch is trivial, I guess you still want to let =

know

quoted

PowerPC folks about it. Adding Cc and copying the patch:
=20
- - - -
From: Jerry Huang <redacted>
=20
Below SOCs don't support the cmd23 command for MMC card, therefore,
disable it in device tree:
P1020, P1021, P1022, P1024, P1025 and P4080
=20
Signed-off-by: Jerry Huang <redacted>
CC: Anton Vorontsov <redacted>
---
arch/powerpc/boot/dts/fsl/p1020si-post.dtsi |    1 +
arch/powerpc/boot/dts/fsl/p1021si-post.dtsi |    1 +
arch/powerpc/boot/dts/fsl/p1022si-post.dtsi |    1 +
arch/powerpc/boot/dts/fsl/p4080si-post.dtsi |    1 +
4 files changed, 4 insertions(+)
=20

diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi

b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
index 68cc5e7..793a30b 100644

--- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi

@@ -154,6 +154,7 @@

	sdhc@2e000 {
		compatible =3D "fsl,p1020-esdhc", "fsl,esdhc";
		sdhci,auto-cmd12;
+		sdhci,no-cmd23;
	};
/include/ "pq3-sec3.3-0.dtsi"
=20

diff --git a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi

b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi
index adb82fd..2b7fd2a 100644

--- a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi

@@ -149,6 +149,7 @@

/include/ "pq3-esdhc-0.dtsi"
	sdhc@2e000 {
		sdhci,auto-cmd12;
+		sdhci,no-cmd23;
	};
=20
/include/ "pq3-sec3.3-0.dtsi"

diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi

b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
index 06216b8..2334a52 100644

--- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi

@@ -215,6 +215,7 @@

	sdhc@2e000 {
		compatible =3D "fsl,p1022-esdhc", "fsl,esdhc";
		sdhci,auto-cmd12;
+		sdhci,no-cmd23;
	};
=20
/include/ "pq3-sec3.3-0.dtsi"

diff --git a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi

b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi
index 8d35d2c..5b39952 100644

--- a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi

@@ -337,6 +337,7 @@

	sdhc@114000 {
		voltage-ranges =3D <3300 3300>;
		sdhci,auto-cmd12;
+		sdhci,no-cmd23;
	};
=20
/include/ "qoriq-i2c-0.dtsi"
--
1.7.9.5

=20