Re: [PATCH] powerpc/fsl: mpic timer driver

On 07/31/2012 09:31 AM, Kumar Gala wrote:

On Jul 31, 2012, at 2:58 AM, Wang Dongsheng-B40534 wrote:

quoted

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, July 27, 2012 9:14 PM
To: Wang Dongsheng-B40534
Cc: benh@kernel.crashing.org; paulus@samba.org; Wood Scott-B07421;
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/fsl: mpic timer driver


On Jul 27, 2012, at 1:20 AM, [off-list ref]
[off-list ref] wrote:

quoted

From: Wang Dongsheng <redacted>

Global timers A and B internal to the PIC. The two independent groups
of global timer, group A and group B, are identical in their

functionality.

quoted

The hardware timer generates an interrupt on every timer cycle.
e.g
Power management can use the hardware timer to wake up the machine.

Signed-off-by: Wang Dongsheng <redacted>
Signed-off-by: Li Yang <redacted>

How much of this is FSL specific vs openpic?  OpenPIC spec's timer
support (only a single group).

[Wang Dongsheng] Yes, OpenPIC only a single group timer.
FSL: add more register, features and group.
This patch only to support FSL chip.
"mpic_timer.c" -> "fsl_mpic_timer.c"
I will modify the description of the patch. how about?

I'd rather we support both, can we not use the MPIC_FSL flag to deal with FSL specific behavior?

The device this driver binds against is "fsl,mpic-global-timer".  We
don't have a binding for ordinary OpenPIC timers, and inferring them
from the basic OpenPIC node will cause AMP headaches.

Let someone who cares about ordinary OpenPIC drivers add support. :-)

-Scott