RE: [2/3][PATCH][v2] TDM Framework

-----Original Message-----
From: Linuxppc-dev [mailto:linuxppc-dev-
bounces+poonam.aggrwal=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Gre=

g

KH
Sent: Friday, July 27, 2012 11:42 PM
To: Singh Sandeep-B37400
Cc: devel@driverdev.osuosl.org; linuxppc-dev@lists.ozlabs.org; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [2/3][PATCH][v2] TDM Framework
=20
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sandeep@freescale.com wrote:

quoted

+static struct kobj_type tdm_type =3D {
+	.sysfs_ops =3D &tdm_ops,
+	.default_attrs =3D tdm_attr,
+};

=20
Ah, also, as per the documentation in the kernel (go look, it's there), I
now get to publicly mock you for ignoring the error messages that the
kernel is giving you when you try to shut down your code path.
=20
Well, to be fair, you are leaking memory like a sieve, so I doubt you
ever saw those error messages because you never cleaned up after
yourself, so perhaps I can forgive you, but your users can't, sorry.
They like to rely on the fact that Linux is a reliable operating system,
don't cause them to doubt that.
=20
Please fix this code, it's horribly broken.  Read
Documentation/kobject.txt for why.  That file was written for a reason,
and not just because we like writing documentation (hint, we hate to...)

To be honest we are not sysfs experts. Thanks for pointing to the documenta=
tion.
We will rework the stuff.

Regards
Poonam

=20
Ugh,
=20
greg k-h
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev