Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

Zhao Chenhui wrote:

On Tue, Jul 03, 2012 at 10:17:12PM -0500, Tabi Timur-B04825 wrote:

quoted

Zhao Chenhui wrote:

quoted

If the guts variable is NULL, it indicates there is error in dts or ker=

nel.

quoted

quoted

We should fix the error, rather than ignore it.

And that's why there's a warning message.  Crashing the kernel is not
going to fix anything.

This error likely crashes the kenel somewhere.

Can you test this, please?

The point I'm trying to make is that it's wrong to intentionally halt the=20
kernel unless you're sure that it's the best option.  A missing device=20
tree node is supposed to only disable a given feature, not break everything=
.

--=20
Timur Tabi
Linux kernel developer at Freescale