Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

On Tue, Jul 3, 2012 at 5:21 AM, Zhao Chenhui [off-list ref] w=
rote:

+       np =3D of_find_matching_node(NULL, mpc85xx_smp_guts_ids);
+       if (np) {
+               guts =3D of_iomap(np, 0);
+               of_node_put(np);
+               if (!guts) {
+                       pr_err("%s: Could not map guts node address\n",
+                                                               __func__)=

;

+                       return;
+               }
+               smp_85xx_ops.give_timebase =3D mpc85xx_give_timebase;
+               smp_85xx_ops.take_timebase =3D mpc85xx_take_timebase;
+       }

I had this in mind:

               guts =3D of_iomap(np, 0);
               of_node_put(np);
               if (guts) {
                       smp_85xx_ops.give_timebase =3D mpc85xx_give_timebase=
;
                       smp_85xx_ops.take_timebase =3D mpc85xx_take_timebase=
;
                } else {
                       pr_err("%s: Could not map guts node address\n",
                                                               __func__);
               }

That way, a missing GUTS node does not break everything.

--=20
Timur Tabi
Linux kernel developer at Freescale=