Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn()

* Ingo Molnar [off-list ref] [2012-06-06 11:40:15]:

* Ananth N Mavinakayanahalli [off-list ref] wrote:

quoted

On Wed, Jun 06, 2012 at 11:23:52AM +0200, Peter Zijlstra wrote:

quoted

On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote:

quoted

+int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, loff_t vaddr)

Don't we traditionally use unsigned long to pass vaddrs?

Right. But the vaddr we pass here is vma_info->vaddr which is loff_t.
I guess I should've made that clear in the patch description.

Why not fix struct vma_info's vaddr type?

Calculating and comparing vaddr results either uses variables of type loff_t. 
To avoid typecasting and avoid overflow at each of these places, we used
loff_t. 

Ananth, install_breakpoint() already has a variable of type addr of type
unsigned long.  Why dont you use addr instead of vaddr. 

-- 
Thanks and regards
Srikar