Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

On Sat, 2012-04-28 at 10:52 +0200, Borislav Petkov wrote:

On Fri, Apr 27, 2012 at 01:07:38PM -0300, Mauro Carvalho Chehab wrote:

quoted

Yes. This is a common issue at the EDAC core: on several places, it calls the
edac debug macros (DEBUGF0...DEBUGF4) passing a __func__ as an argument, while
the debug macros already handles that. I suspect that, in the past, the __func__
were not at the macros, but some patch added it there, and forgot to fix the
occurrences of its call.

The patch that added it is d357cbb445208 and you reviewed it.

quoted

This is something that needs to be reviewed at the entire EDAC core (and likely
at the drivers).

Looks like a job for a newbie to get her/his feet wet with kernel work.

Looks to me more like a lazy maintainer/developer who doesn't
want to bother with a few minutes work.