Thread (33 messages) flat view 33 messages, 4 authors, 2012-04-30

Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers

From: Joe Perches <joe@perches.com>
Date: 2012-04-28 17:07:58
Also in: lkml

Possibly related (same subject, not in this thread)

On Sat, 2012-04-28 at 11:16 +0200, Borislav Petkov wrote:
On Fri, Apr 27, 2012 at 02:52:35PM -0300, Mauro Carvalho Chehab wrote:
quoted
quoted
All those local variables should be sorted in a reverse christmas tree
order:

	u32 this_is_the_longest_array_name[LENGTH];
	void *shorter_named_variable;
	unsigned long size;
	int i;

	...
Why? There's nothing at the CodingStyle saying about how the vars should
be ordered. If you want to enforce some particular order, please do it
yourself, but apply it consistently among the entire subsystem.
First of all, this way it is more readable.
Not in my opinion, and blindly using "reverse christmas tree"
can separate variables that should be declared together.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help