Re: [PATCH 2/2] powerpc: add support for MPIC message register API

On Feb 16, 2012, at 8:49 PM, Jia Hongtao wrote:

Some MPIC implementations contain one or more blocks of message =

registers

that are used to send messages between cores via IPIs.  A simple API =

has

been added to access (get/put, read, write, etc ...) these message =

registers.

The available message registers are initially discovered via nodes in =

the

device tree.  A separate commit contains a binding for the message =

register

nodes.
=20
Signed-off-by: Meador Inge <redacted>
Signed-off-by: Jia Hongtao <redacted>
Signed-off-by: Li Yang <redacted>
---
This patch is an update for : http://patchwork.ozlabs.org/patch/98075/
=20
Meador Inge addressed the following points from Ben's feedback:
* Drop the 'mpic_msgr.msr' field.
* Drop the 'mpic_msgr.mer' field in favor of address arithmetic off of =

 'mpic_msgr.addr'.

* Document the API.
* Disable MPIC register in 'mpic_msgr_put'.
* Put locking in 'mpic_msgr_disable'.
* s/EXPORT_SYMBOL/EXPORT_SYMBOL_GPL/g.
* Make 'mpic_msgr_write' and 'mpic_msgr_read' 'static inline'.
=20
I just fixed the checkpatch errors and addressed the following item:
* In 'mpic_msgr_set_destination' have a wrapper that goes from Linux
 CPU number to HW CPU number.
=20
arch/powerpc/include/asm/mpic_msgr.h |  132 ++++++++++++++++
arch/powerpc/platforms/Kconfig       |    8 +
arch/powerpc/sysdev/Makefile         |    2 +
arch/powerpc/sysdev/mpic_msgr.c      |  282 =

++++++++++++++++++++++++++++++++++

4 files changed, 424 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/include/asm/mpic_msgr.h
create mode 100644 arch/powerpc/sysdev/mpic_msgr.c

applied

- k=