RE: [linuxppc-release] [PATCH 1/2] powerpc: document the FSL MPIC message register binding

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, February 17, 2012 6:48 PM
To: Yoder Stuart-B08248
Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; meador_inge@mentor=

.com; Li Yang-R58472

Subject: Re: [linuxppc-release] [PATCH 1/2] powerpc: document the FSL MPI=

C message register

binding
=20
On 02/17/2012 09:50 AM, Yoder Stuart-B08248 wrote:

quoted

quoted

-----Original Message-----
From: linuxppc-release-bounces@linux.freescale.net
[mailto:linuxppc-release- bounces@linux.freescale.net] On Behalf Of
Jia Hongtao-B38951
Sent: Thursday, February 16, 2012 8:49 PM
To: linuxppc-dev@lists.ozlabs.org
Cc: meador_inge@mentor.com; Li Yang-R58472; Jia Hongtao-B38951
Subject: [linuxppc-release] [PATCH 1/2] powerpc: document the FSL
MPIC message register binding

This binding documents how the message register blocks found in some
FSL MPIC implementations shall be represented in a device tree.

Signed-off-by: Meador Inge <redacted>
Signed-off-by: Jia Hongtao <redacted>
Signed-off-by: Li Yang <redacted>
---
 .../devicetree/bindings/powerpc/fsl/mpic-msgr.txt  |   62 +++++++++++=

+++++++++

quoted

quoted

 1 files changed, 62 insertions(+), 0 deletions(-)  create mode
100644 Documentation/devicetree/bindings/powerpc/fsl/mpic-msgr.txt

diff --git
a/Documentation/devicetree/bindings/powerpc/fsl/mpic-msgr.txt
b/Documentation/devicetree/bindings/powerpc/fsl/mpic-msgr.txt
new file mode 100644
index 0000000..b4ae70e

--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/mpic-msgr.txt

@@ -0,0 +1,62 @@
+* FSL MPIC Message Registers
+
+This binding specifies what properties must be available in the
+device tree representation of the message register blocks found in
+some FSL MPIC implementations.
+
+Required properties:
+
+    - compatible: Specifies the compatibility list for the message re=

gister

quoted

quoted

+      block.  The type shall be <string> and the value shall be of th=

e form

quoted

quoted

+      "fsl,mpic-v<version>-msgr", where <version> is the version numb=

er of

quoted

quoted

+      the MPIC containing the message registers.

The type for compatibles is a <string-list>.

quoted

+    - reg: Specifies the base physical address(s) and size(s) of the
+      message register block's addressable register space.  The type =

shall be

quoted

quoted

+      <prop-encoded-array>.
+
+    - interrupts: Specifies a list of interrupt source and level-sens=

e pairs.

quoted

quoted

+      The type shall be <prop-encoded-array>.  The length shall be eq=

ual to

quoted

quoted

+      the number of registers that are available for receiving interr=

upts.

quoted

How many interrupts are there?   If more than 1,  this is where
you need to specify what each interrupt is for.

=20
They aren't "for" anything in particular -- each interrupt is associated =

with a message

register.  The binding does say that the number of interrupts corresponds=

 to the bits set in

the receive mask.

Then make that clear, it also should use the term 'interrupt-specifier'
not 'interrupt source and level-sense pairs', which implies a particular
parent interrupt controller configuration.

Stuart