Re: [PATCH 20/21] Introduce struct eeh_stats for EEH
From: Michael Ellerman <hidden>
Date: 2012-02-29 12:56:44
On Tue, 2012-02-28 at 14:04 +0800, Gavin Shan wrote:
With the original EEH implementation, the EEH global statistics are maintained by individual global variables. That makes the code a little hard to maintain.
Hi Gavin,
quoted hunk ↗ jump to hunk
@@ -1174,21 +1182,24 @@ static int proc_eeh_show(struct seq_file *m, void *v) { if (0 == eeh_subsystem_enabled) { seq_printf(m, "EEH Subsystem is globally disabled\n"); - seq_printf(m, "eeh_total_mmio_ffs=%ld\n", total_mmio_ffs); + seq_printf(m, "eeh_total_mmio_ffs=%d\n", eeh_stats.total_mmio_ffs); } else { seq_printf(m, "EEH Subsystem is enabled\n"); seq_printf(m, - "no device=%ld\n" - "no device node=%ld\n" - "no config address=%ld\n" - "check not wanted=%ld\n" - "eeh_total_mmio_ffs=%ld\n" - "eeh_false_positives=%ld\n" - "eeh_slot_resets=%ld\n", - no_device, no_dn, no_cfg_addr, - ignored_check, total_mmio_ffs, - false_positives, - slot_resets); + "no device =%d\n" + "no device node =%d\n" + "no config address =%d\n" + "check not wanted =%d\n" + "eeh_total_mmio_ffs =%d\n" + "eeh_false_positives =%d\n" + "eeh_slot_resets =%d\n",
There *might* be tools out there that parse this output, so I'd say don't change it unless you have to - and I don't think you have to? cheers
Attachments
- signature.asc [application/pgp-signature] 836 bytes