Thread (35 messages) flat view 35 messages, 5 authors, 2012-04-17

Re: [PATCH 20/21] Introduce struct eeh_stats for EEH

From: Gavin Shan <hidden>
Date: 2012-02-29 01:08:44

 
quoted
+struct eeh_stats {
+	unsigned int no_device;		/* PCI device not found */
...
quoted
+				"no device           =%d\n"
...

Use %u (for all the stats), you really don't want negative
values printed.
Yes. 
I've NFI how long wrapping these counters might take!
If it is feasable (maybe much above 100Hz) then you
need 64bit counters.
I think it's better to use "u64" here ;-)
	David
Thanks,
Gavin
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help