Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

On Aug 8, 2011, at 6:18 AM, Julia Lawall wrote:

From: Julia Lawall <redacted>

At this point, ehv_pic has been allocated but not stored anywhere, so it
should be freed before leaving the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@exists@
local idexpression x;
statement S,S1;
expression E;
identifier fl;
expression *ptr != NULL;
@@

x = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
    when != if (...) { <+...kfree(x)...+> }
    when any
    when != true x == NULL
x->fl
...>
(
if (x == NULL) S1
|
if (...) { ... when != x
              when forall
(
return \(0\|<+...x...+>\|ptr\);
|
* return ...;
)
}
)
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
arch/powerpc/sysdev/ehv_pic.c |    1 +
1 file changed, 1 insertion(+)

applied to next

- k