Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree
From: Tabi Timur-B04825 <hidden>
Date: 2011-08-15 22:55:35
Also in:
kernel-janitors, lkml
On Mon, Aug 8, 2011 at 7:18 AM, Julia Lawall [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.=
c
quoted hunk ↗ jump to hunk
index af1a5df..b6731e4 100644--- a/arch/powerpc/sysdev/ehv_pic.c +++ b/arch/powerpc/sysdev/ehv_pic.c@@ -280,6 +280,7 @@ void __init ehv_pic_init(void)=A0 =A0 =A0 =A0if (!ehv_pic->irqhost) { =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0of_node_put(np); + =A0 =A0 =A0 =A0 =A0 =A0 =A0 kfree(ehv_pic); =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; =A0 =A0 =A0 =A0}
Although the fix is correct, I think there is another bug in this function. 'np' is not released when the function finishes successfully. I've looked at other functions that use irq_alloc_host(), and most of them do the same thing: they don't call of_node_put() on the device node pointer. The only exception I've found is mpc5121_ads_cpld_pic_init(). Ben, Kumar: am I missing something? irq_alloc_host() calls of_node_get(): host->of_node =3D of_node_get(of_node); so doesn't that mean that the caller of irq_alloc_host() should release the device node pointer? --=20 Timur Tabi Linux kernel developer at Freescale=