Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

From
Avi Kivity <hidden>
Date
2011-07-04 11:38:00
Also in
kvm
Reply to
Alexander Graf, 2011-07-04
On 07/04/2011 02:36 PM, Alexander Graf wrote:
quoted
 What intermediate steps?  We can't add fields to the structure before we get the extensibility infrastructure, but that's all.
If we add it now without extensibility code, we will have a kernel that only knows the ioctl with the size as it is now. If we later add another field, the ioctl size changes which would render new user space running on that particular kernel to fail, because it doesn't have the "just truncate the ioctl param to the size" logic yet.
You're right.  So let's add the padding now, and only use the great new stuff after it's actually in.

Working ugly is better than broken pretty.

-- 
error compiling committee.c: too many arguments to function
Thread (51 messages) 51 messages, 6 authors, 2012-04-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help