Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate

On 03.07.2011, at 11:12, Avi Kivity wrote:

On 07/03/2011 12:09 PM, Alexander Graf wrote:

quoted

quoted

 Right.  The idea is that if KVM_FLAG_BLAH implies a field =

kvm_struct::blah, then either both are present in the headers, or none  =
of them.

quoted

=20
Yup, makes sense. I like the idea :). Gets rid of all the useless =

paddings and reserved fields. We could even truncate the structs that =
already have paddings in them if we only copy min(sizeof(real_struct), =
ioctl_passed_size); (which we should anyways).

quoted

=20

=20
No, we can't change anything that is already out.  If will change the =

ioctl numbers, so building against new headers but running against an =
old kernel will fail.

So this will only be enabled for completely new ioctls?

=20

quoted

How long until we get a patch set? :)

=20
Well, I'd really like to get the qemu memory API out first.

Can we add the ioctl without padding now then and add your awesome =
extensibility stuff to it later on? We only have to make sure we don't =
actually release the intermediate steps as an upstream kernel then, =
right?


Alex