On 04/28/2011 10:00 PM, Kushwaha Prabhakar-B32579 wrote:

Hi,

I have no comments about coding and architecture. It looks fine.

Only have a query about its use case..
   "Any application intended to use message interrupt requires to know reg_num because of struct mpic_msgr* mpic_msgr_get(unsigned int reg_num) API"

It will be good to search available unit internally and provide its pointer. It will make application more flexible.

The problem is that you fundamentally cannot implement an allocator for 
MSG registers if you're going to communicate with another kernel (how 
would both kernels' allocators be synchronized?). So the message 
register allocation must be decided at design time, not run time.

Hollis Blanchard
Mentor Graphics, Embedded Systems Division