Re: [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset.

On Tue, Jun 08, 2010 at 12:46:02PM -0400, Eric Millbrandt wrote:

+       switch (psc_dma->id) {
+       case 0:
+               gpio_mux = MPC52xx_GPIO_PSC1_MASK; break;
+       case 1:
+               gpio_mux = MPC52xx_GPIO_PSC2_MASK; break;

Please don't place the break on the same line as the statement, it's
not good for legibility.

+       dev_err(psc_dma->dev, "cold reset\n");

You shouldn't be logging this as an error, doing a cold reset is
perfectly normal.