Thread (43 messages) 43 messages, 11 authors, 2010-07-08

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

From: Anton Vorontsov <hidden>
Date: 2010-06-22 16:55:55
Also in: lkml

On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote:
[...]
quoted
               jid = jedec_probe(spi);
               if (!jid) {
-                       dev_info(&spi->dev, "non-JEDEC variant of %s\n",
-                                id->name);
+                       return -ENODEV;
The patch looks good to me. Only problem is NULL is also returned by
spi_write_then_read() fail:
[...]
Here much better for -EIO (return tmp)?
Agreed. Though, this is not a regression, and I guess desires
its own patch. 

Here are two patches, one for 2.6.35 (minimal changes to fix
the JEDEC problem), another for 2.6.36.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help