Re: [PATCH 03/11] powerpc/mpc5121: Add machine restart support

On Wed, 20 Jan 2010 12:28:43 +0100
Wolfram Sang [off-list ref] wrote:

quoted

+static void __iomem *reset_module_base;

type here also?

Ok.

quoted

+
+static int __init mpc512x_restart_init(void)
+{
+	struct device_node *np;
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mpc5121-reset");
+	if (!np)
+		return -1;
+
+	reset_module_base = of_iomap(np, 0);
+	of_node_put(np);
+
+	return 0;
+}
+

Drop this empty line?

Ok.

quoted

+	} else {
+		printk(KERN_ERR ": Restart module not mapped.\n");

The colon is a leftover?

Yes, will fix for using pr_error() and resubmit.

Thanks,
Anatolij