Thread (33 messages) 33 messages, 8 authors, 2010-01-26

Re: [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support

From: Grant Likely <hidden>
Date: 2010-01-21 17:12:39
Also in: linux-i2c

On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Piotr Ziecik <redacted>

=A0 =A0- Update Kconfig for i2c-mpc driver.
=A0 =A0- Enable I2C interrupts on MPC5121.
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index f627001..84eeb25 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -540,6 +540,29 @@ static int __devinit fsl_i2c_probe(struct of_device =
*op,
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
=A0 =A0 =A0 =A0}

+ =A0 =A0 =A0 if (of_device_is_compatible(op->node, "fsl,mpc5121-i2c")) {
Rather than doing stuff like this with explicit compatible checks in
the probe hook, consider using the .data pointer in the of match
table.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help