On Sun, 17 May 2009 10:25:31 +0200
Geert Uytterhoeven [off-list ref] wrote:

On Sun, May 17, 2009 at 10:06, Krzysztof Helt [off-list ref] wr=

ote:

quoted

On Fri, 15 May 2009 12:19:17 -0600 Grant Likely <grant.likely@secretlab=

.ca> wrote:

quoted

quoted

diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index 40a3a2a..7a868bd 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c

@@ -107,17 +111,28 @@ static struct fb_var_screeninfo xilinx_fb_var =

=3D {

quoted

quoted

=A0 =A0 =A0 .activate =3D =A0 =A0 FB_ACTIVATE_NOW
=A0};

+
+#define PLB_ACCESS_FLAG =A0 =A0 =A00x1 =A0 =A0 =A0 =A0 =A0 =A0 /* 1 =

=3D PLB, 0 =3D DCR */

quoted

quoted

+
=A0struct xilinxfb_drvdata {

=A0 =A0 =A0 struct fb_info =A0info; =A0 =A0 =A0 =A0 =A0 /* FB driver i=

nfo record */

quoted

quoted

- =A0 =A0 u32 =A0 =A0 =A0 =A0 =A0 =A0 regs_phys; =A0 =A0 =A0/* phys. a=

ddress of the control registers */

quoted

quoted

- =A0 =A0 u32 __iomem =A0 =A0 *regs; =A0 =A0 =A0 =A0 =A0/* virt. addre=

ss of the control registers */

quoted

quoted

+ =A0 =A0 phys_addr_t =A0 =A0 regs_phys; =A0 =A0 =A0/* phys. address o=

f the control

quoted

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =

=A0 =A0 =A0 =A0 =A0 registers */

quoted

There are fields fb_info.fix.mmio_start and fb_info.fix.mmio_len for
physical IO range used by framebuffer. There is no field for
virtual IO address so the "regs" below must stay.

=20
If I'm not mistaken, this driver is used on ppc44x, where phys_addr_t is =

64-bit,

so the 32-bit unsigned long fb_info.fix.mmio_start is not large enough
to hold the
physical address.
=20

If so please ignore my comment.

Acked-by: Krzysztof Helt <redacted>

Regards,
Krzysztof

----------------------------------------------------------------------
Dzwonki na komorkê!
Sprawdz >> http://link.interia.pl/f2161